Skip to content

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 13, 2024

Fixes #30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.

@KN4CK3R KN4CK3R added this to the 1.22.0 milestone May 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2024
@KN4CK3R KN4CK3R added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code and removed backport/v1.22 This PR should be backported to Gitea 1.22 labels May 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2024
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@silverwind
Copy link
Member

I think you need to alter swagger comment docs to indicate the possibility for any new status codes.

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2024
@lunny lunny enabled auto-merge (squash) May 14, 2024 06:21
@lunny lunny merged commit b1d8f13 into go-gitea:main May 14, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 14, 2024
Fixes go-gitea#30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 14, 2024
KN4CK3R added a commit that referenced this pull request May 14, 2024
Backport #30962 by @KN4CK3R

Fixes #30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.

Co-authored-by: KN4CK3R <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2024
* giteaofficial/main:
  Protected tag is no internal server error (go-gitea#30962)
  [skip ci] Updated translations via Crowdin
  Restyle release list, fix branch dropdown (go-gitea#30837)
  fix: change npm scope registry (go-gitea#30964)
  Support using label names when changing issue labels (go-gitea#30943)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 12, 2024
@KN4CK3R KN4CK3R deleted the fix-protected-tag-30959 branch December 3, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird HTTP code when invalid tag name is provided
5 participants